Force html templates to reload when development mode is enabled #8019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm it works 👍 |
mnapoli
added a commit
that referenced
this pull request
May 29, 2015
Force html templates to reload when development mode is enabled
mattab
added
the
answered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on server configuration or browser some angular templates are sometimes not reloaded because the cacheBuster only changes if also a JS file changes.
This PR will create a random cache buster if development is enabled. The cache buster is for example used like this: https://github.com/piwik/piwik/blob/2.14.0-b1/plugins/MultiSites/angularjs/site/site.directive.js#L38
Disadvantage of this solution is that templates will be always reloaded even if a cached version (browser cache) could be used when development is enabled