Moved Intl data translations to a new plugin #8017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
the
Pull Request WIP
sgiehl
force-pushed
the
i18n-data-extended
branch
5 times, most recently
from
98cd4f8
to
bd85069
Compare
sgiehl
force-pushed
the
i18n-data-extended
branch
from
bd85069
to
cc57e57
Compare
sgiehl
added
Needs Review
mattab
pushed a commit
that referenced
this pull request
Jun 8, 2015
Moved Intl data translations to a new plugin
mattab
added
the
Task
|
LGTM. Especially nice that it can be improved later and add more strings from i18n project, to save time to our translators, and save them from translating incorrectly those important date/time strings. |
|
@sgiehl I noticed a small regression, in French for example, translation for "Today" becomes "aujourd'hui". Expected to get "Aujourd'hui" with ucfirst/ capital letter. Maybe the Intl data has the version with capital letter first? or maybe we can use
|
|
No. There's no data with other cases. In Germany the first letters are uppercase. Not sure why they aren't for French. I could apply a ucfirst when importing those data... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to move the Intl-data translations away from core into a new plugin.
That makes it much easier to handle the translations and doesn't make it necessary to change to much in the translation logic.
I've also reverted some of the changes made before, as they weren't needed anymore.
The Intl-Plugin now contains the translations for:
I maybe add some more stuff as cldr also contains translations for date fields like
tomorrow,yesterday,day,week,month,yearand so onNote: Some language names have changed, but I think we should use those provided by CLDR, as they might be more correct than those we used.