Deactivating a plugin: clear the caches before unloading the plugin #8016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin is used for clearing the caches, so it needs to be unloaded after.
mnapoli
added
Bug
|
Can you trigger the bug in a test? |
|
I think these two things would help in checking that there are no side effects:
This is just from looking at the existing code, though. I haven't worked w/ this code in a while, so I don't know of any specific issues. |
|
LGTM. Not merging directly since there were some other comments |
|
I've added a test covering that and had a look at the code, couldn't find usage of the cache. |
mnapoli
added a commit
that referenced
this pull request
Jun 5, 2015
Deactivating a plugin: clear the caches before unloading the plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8007
The plugin instance is used for clearing the caches, so it needs to be unloaded after the caches are cleared. I'm opening for review because I am not certain what I'm doing isn't affecting other parts :/ (and maybe there's a better solution)
For the record it started to show the warning after a20e71c fixed a bug (unloading plugins wasn't really unloading before) which made this bug more visible (so it may have been partially broken for some time before).