Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove magic quote hacks before 3.0 is released #8012

Closed
diosmosis opened this issue May 28, 2015 · 2 comments · Fixed by #10001
Closed

Remove magic quote hacks before 3.0 is released #8012

diosmosis opened this issue May 28, 2015 · 2 comments · Fixed by #10001
Assignees
@tsteur
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
3.0.0-b1

Comments

@diosmosis
Copy link
Member

As title, when the minimum required PHP version is increased to 5.4 since magic quotes does not exist there.
@diosmosis diosmosis added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label May 28, 2015
@diosmosis diosmosis added this to the 3.0.0 milestone May 28, 2015
@mattab mattab added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Aug 13, 2015
@mattab mattab modified the milestones: 3.0.0, 3.0.0-b1 Oct 1, 2015
@tsteur
Copy link
Member

tsteur commented Mar 9, 2016

I think pretty much only https://github.com/piwik/piwik/blob/3.0/core/bootstrap.php#L20 is left. https://github.com/piwik/piwik/blob/2.16.0/core/Common.php#L280 and other places were already removed

@tsteur tsteur self-assigned this Apr 4, 2016
tsteur added a commit that referenced this issue Apr 4, 2016
@tsteur
fixes #8012 Remove magic quote hacks as now PHP 5.5 is required
fed8a62
@tsteur tsteur mentioned this issue Apr 4, 2016
Merged
@tsteur
Copy link
Member

tsteur commented Sep 13, 2016

this is done

@tsteur tsteur closed this as completed Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
3.0.0-b1
Development

Successfully merging a pull request may close this issue.

Remove magic quote hacks as now PHP 5.5 is required matomo-org/matomo
3 participants
@diosmosis @tsteur @mattab