Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that WhiteLabel plugin still work as expected after all redesigns (before releasing Piwik 2.14.0) #8006

Closed
mattab opened this issue May 27, 2015 · 4 comments
Closed

Verify that WhiteLabel plugin still work as expected after all redesigns (before releasing Piwik 2.14.0) #8006

mattab opened this issue May 27, 2015 · 4 comments
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.14.0

Comments

@mattab
Copy link
Member

mattab commented May 27, 2015 •
edited

The goal of this issue is that, before we release 2.14.0 release, we must check that the WhiteLabel plugin screenshot tests (and others) are passing and that it has not regressed.

Why is this important?

We are making many design improvements in this release 2.14.0. As part of these projects we are changing a lot of HTML, CSS and some JavaScript. Our UI tests let us know that we have not regressed anything in core Piwik which is great. But we need to ensure that White Label, a premium plugin, works still after we changed all this CSS and HTML.

cc @mnapoli
@mattab mattab added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels May 27, 2015
@mattab mattab added this to the 2.14.0 milestone May 27, 2015
@mnapoli
Copy link
Contributor

mnapoli commented May 27, 2015

👍 FYI working currently on a UI test that activates another theme (to have that covered).

@mnapoli
Copy link
Contributor

mnapoli commented May 28, 2015

UI test for themes: #8015

@mnapoli
Copy link
Contributor

mnapoli commented May 28, 2015

For the record I have run the UI tests locally in the #8015 branch and they fail only because of redesigned elements, but the colors and overridden styles are taken into account! So it should be good (but let's check again before 2.14 release).

@mattab mattab mentioned this issue May 29, 2015
Closed
@mattab
Copy link
Member Author

mattab commented Jun 24, 2015

a new WhiteLabel plugin release was done (0.8.1) and it looks good with 2.14.0 👍

@mattab mattab closed this as completed Jun 24, 2015
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
2 participants
@mattab @mnapoli