Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New design for the site manager #8002

Merged
merged 7 commits into from Jun 4, 2015
Merged

New design for the site manager #8002

merged 7 commits into from Jun 4, 2015

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented May 26, 2015

Do not merge

This is an alternative design for #8001 (redesign of the site manager).

I've taken a different approach here to stay more in line with the original mockup but less borders (inspired a bit by "cards" of material design: the outline of the block is done by the shadow).

Feel free to 👎 or suggest alternative routes, I'm just trying out things ;)

capture d ecran 2015-05-26 a 14 28 28

@mnapoli mnapoli added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels May 26, 2015
@mnapoli mnapoli added this to the 2.14.0 milestone May 26, 2015
@diosmosis
Copy link
Member

Looks cool, 👍

@tsteur
Copy link
Member

tsteur commented Jun 1, 2015

Prefer this one as it scales more than #8001 . We cannot add an unlimited number of columns in #8001 whereas this one here scales. Plugins / Types can add more information to the 2 existing columns in the middle making it much more usable and look better. Also it allows us to show different information eg App-ID for mobile apps and URL's for websites. In #8001 we wouldn't be able to show any of those information. The layout of #8001 gets way too wide making it look weird and a bit unprofessional.

Also we can make this version responsive maybe. If there's not as much space we just show the columns below each other. Whereas it wouldn't really be possible to make #8001 responsive

@tsteur
Copy link
Member

tsteur commented Jun 2, 2015

@mnapoli is there much missing or could we merge?

@mnapoli
Copy link
Contributor Author

mnapoli commented Jun 2, 2015

@tsteur FYI I think it should be responsive out of the box (used bootstrap grid) but the admin screens have a fixed width so it cannot be really used right now.

This PR can't be merged yet because it is based on #7960 (forms redesign). I need to adjust a few things there (comments) + check for regressions. I'll focus on this to try to merge this ASAP.

@@ -7,266 +7,276 @@
help-url="http://piwik.org/docs/privacy/">{{ 'PrivacyManager_TeaserHeadline'|translate }}</h2>
<p>{{ 'PrivacyManager_Teaser'|translate('<a href="#anonymizeIPAnchor">',"</a>",'<a href="#deleteLogsAnchor">',"</a>",'<a href="#optOutAnchor">',"</a>")|raw }}
{{'PrivacyManager_SeeAlsoOurOfficialGuidePrivacy'|translate('<a href="http://piwik.org/privacy/" rel="noreferrer" target="_blank">','</a>')|raw }}</p>

<h2 id="anonymizeIPAnchor">{{ 'PrivacyManager_UseAnonymizeIp'|translate }}</h2>
<form method="post" action="{{ {'action':'saveSettings', 'form':'formMaskLength', 'token_auth':token_auth} | urlRewriteWithParameters }}" id="formMaskLength">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this mean the token_auth would be sent as a GET parameter? It should be sent as POST to not appear in logs etc

@tsteur
Copy link
Member

tsteur commented Jun 3, 2015

Didn't have a detailed look re HTML or so apart from security. Few comments re token_auth otherwise looks good to me.

@mnapoli mnapoli changed the title Alternative new design for the site manager New design for the site manager Jun 4, 2015
@mnapoli
Copy link
Contributor Author

mnapoli commented Jun 4, 2015

@tsteur could you open a separate issue for security stuff, this is code that I haven't changed.

I have tested the forms, I think this is ready to be merged.

@mnapoli mnapoli removed the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Jun 4, 2015
@tsteur
Copy link
Member

tsteur commented Jun 4, 2015

sweet, just noticed it was in #7960 anyway and not in this PR. Looked like it was added but was there already.

tsteur added a commit that referenced this pull request Jun 4, 2015
@tsteur tsteur merged commit 4ee9985 into master Jun 4, 2015
@tsteur tsteur deleted the redesign-site-manager-2 branch June 4, 2015 21:19
@mnapoli
Copy link
Contributor Author

mnapoli commented Jun 5, 2015

yeah the diff on github is really not as good as the real git diff, it shows changes on big blocks where it's only one e.g. one line in the block that has changed.

@mattab
Copy link
Member

mattab commented Jun 5, 2015

👍 nice PR & UI improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants