New design for the site manager #8001
Conversation
…not particularly helpful
mnapoli
added
Pull Request WIP
mnapoli
removed
the
not-in-changelog
|
Alternative design is here: #8002 |
|
|
||
| {% if isSuperUser %} |
There was a problem hiding this comment.
only super users should be able to view these general settings, is is expected that this if statement was removed?
There was a problem hiding this comment.
Edit: please ignore (the change is actually correct as this template is only created in a controller action that already checks for Super User. )
There was a problem hiding this comment.
Yes I removed this as it was duplicating the check... in the controller (this template is used only there). Thanks for reviewing that though because this extra check made me doubt to remove it ;)
|
Here is my feedback:
|
Could you raise that issue in #7960. FYI I mentioned that there, but Firefox supports theming selects but not Chrome. I did a bit of testing but haven't tested everything yet (e.g. test every field manually), I want to confirm the design and change the things that will need to be changed (visually) and then I will do a final round of complete checks (PR still wip). Maybe I'll try to add a UI test for that, does it make sense?
That's the cache issue I mentioned yesterday in slack. |
|
Closing in favor of #8002 |
This PR is based on #7960 (new design for forms), do not merge
Implementation of the redesign of the site manager introduced in #7587
For the table I went with a simple "table" design with "less lines" (as it was the main problem with the suggested design). I have implemented an alternative design and will open another pull request about it shortly.
I changed the "global settings" form to match the forms redesign (#7960).
I have also remove the auto-scrolling to the form when we click to edit a site: it was very weird and confusing, especially since now the forms are much "taller" (if not convinced please try it out).
Feedback welcome, screenshots below:
Before
After
When editing a site:
Mockup
This is the mockup that was used as a base. As you can see editing a site quite matches the mockup, but the table is far from it (that was intentional based on the feedback in #7587).