New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved i18n data to core/Intl #7996
Conversation
Feedback:
|
I'll rename the console command later. Guess we should also be able to use other parts of unicode-cldr. It also includes names of months & weekdays as well as time formats. I'll have a look at that within the next days |
…nicode-cldr/cldr-localenames-full
…r-localenames-full
Should be finished so far. I'll add some more intl data like continents, day and month names, etc in another PR to keep them small. |
Funnily enough a UI test "broke" because
Except the |
By they way there is no way we download directly the original package (unicode-cldr/cldr-localenames-full) using a package manager? That would avoid having to update the translations if this could be handled by another system like Composer for example. And it would avoid to commit several megabytes in the repo. They have npm or Bower integration, but I'm not sure it's a good idea for us (PHP project) to use this. But it seems there are other packages on Packagist that contain the same data. The thing is: does it make sense to commit such data in Piwik's repository. The idea with core/Intl/Resources was to make it easier to eventually replace it with a 3rd party lib, because why would we maintain that ourselves? |
For sure we could use the full dataset of Small Note: We would only need to run the console command to update the intl data in two cases:
|
Ah OK you only fetch what we need, then 👍 |
Instead of moving the i18n-data to a separate repository, they are now located in
core/Intl
.I've generated those files out of the old Piwik data and used data from unicode-cldr/cldr-localenames-full to improve them.
To make it easy to update those data, I've added a new console command
intl:generate
, that allows updating the files using the current master of unicode-cldr/cldr-localenames-full.