Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Outlinks and Download URLs, do not exclude URL parameters and store URLs untouched #7992

Merged
merged 3 commits into from May 25, 2015

Conversation

mattab
Copy link
Member

@mattab mattab commented May 25, 2015

For Outlinks and Download URLs, do not exclude URL parameters and store URLs untouched

Also adds a missing URL Encoding for action URLs.
(when outlink or download urls contained & and such characters breaking the URL this possibly corrupted the tracking request).

Fixes #6244

…re URLs untouched

Also adds a missing URL Encoding for action URLs.
(when outlink or download urls contained `&` and such characters breaking the URL this possibly corrupted the tracking request).

Fixes #6244
@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 25, 2015
@mattab mattab added this to the 2.14.0 milestone May 25, 2015
@mattab
Copy link
Member Author

mattab commented May 25, 2015

Straightforward change, so feel free to merge if you agree

protected function setActionUrlWithoutExcludingParameters($url)
{
$this->rawActionUrl = PageUrl::getUrlIfLookValid($url);
$this->actionUrl = PageUrl::getUrlIfLookValid($url);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have to call the same method twice here.

Also, this skips the logging in setActionUrl. Perhaps that method can be refactored to call this new method or another one.

@mattab
Copy link
Member Author

mattab commented May 25, 2015

Added integration test + refactored function call, ready for review or merge

@diosmosis
Copy link
Member

System test and UI test failures are random failures. Merging.

diosmosis added a commit that referenced this pull request May 25, 2015
For Outlinks and Download URLs, do not exclude URL parameters and store URLs untouched (with fragment).
@diosmosis diosmosis merged commit 1e9efc7 into master May 25, 2015
@diosmosis diosmosis deleted the 6244 branch May 25, 2015 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants