Implement HTTP-Authentication for transport methods socket & fopen #7980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Needs Review
sgiehl
force-pushed
the
http_authentication
branch
from
97dc68e
to
65214ec
Compare
sgiehl
force-pushed
the
http_authentication
branch
from
65214ec
to
de0a258
Compare
sgiehl
added
Needs Review
|
Is it maybe possible to write tests for it? Not sure if easily doable. If we ever replace |
|
Hm... I'll have a look |
|
I've added some simple tests for checking the response (codes) |
|
|
||
| // try to get http status code from response headers | ||
| if (isset($http_response_header) && preg_match('~^HTTP/(\d\.\d)\s+(\d+)(\s*.*)?~', implode("\n", $http_response_header), $m)) { | ||
| $status = (int)$m[2]; |
There was a problem hiding this comment.
Why do we read the HTTP status code?
mattab
pushed a commit
that referenced
this pull request
May 25, 2015
Implement HTTP-Authentication for transport methods socket & fopen
mattab
added
the
answered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Http-Auth is only possible using curl. Otherwise an exception is raised.
I've implemented Http-Auth for the other transport methods. That is required to let plugin developers update their translations locally if curl is not installed. (The Transifex API requires Http-Auth)
See Thomas--F/BotTracker#20