Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quotes in goal names are over-escaped #7969

Closed
dandv opened this issue May 22, 2015 · 2 comments
Closed

Quotes in goal names are over-escaped #7969

dandv opened this issue May 22, 2015 · 2 comments
Assignees
@diosmosis
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.14.1

Comments

@dandv
Copy link
Contributor

dandv commented May 22, 2015

I created a goal Click "Let me in!" and got this:

image
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label May 24, 2015
@mattab mattab added this to the 2.14.0 milestone May 24, 2015
@mattab
Copy link
Member

mattab commented May 24, 2015

Hi @dandv
Thanks for letting us know about this issue.

@mnapoli mnapoli mentioned this issue May 28, 2015
Closed
@diosmosis diosmosis mentioned this issue May 29, 2015
Closed
@diosmosis diosmosis self-assigned this Jun 2, 2015
@diosmosis
Copy link
Member

Caused very indirectly by https://github.com/piwik/piwik/blob/master/plugins/Goals/Controller.php#L77

@mattab mattab modified the milestones: 2.14.1, 2.14.0 Jun 16, 2015
@diosmosis diosmosis mentioned this issue Jun 26, 2015
Merged
mattab pushed a commit that referenced this issue Jul 12, 2015
Merge pull request #8231 from piwik/7969_goals_output_escaping
e98f405 
Fixes #7969 escape goal names and patterns on output in goals controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.14.1
Development

No branches or pull requests
3 participants
@dandv @diosmosis @mattab