You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When no config file exist (in the Plugin Manager):
$plugins = @Config::getInstance()->Plugins['Plugins'];
// $plugins is null$this->makePluginsToLoad($plugins);
// null is passed in the parameter, the catchable fatal error is somehow silenced because suppressedprivatefunctionmakePluginsToLoad(array$pluginsToLoad)
{
$pluginsToLoad = array_unique($pluginsToLoad);
// ... $pluginsToLoad stays null…return$pluginsToLoad; // returns NULL
}
This affects the loading of DI config (and maybe other things?): no plugin DI config is loaded. Additionally even when this is fixed, the Diagnostics plugin should always be loaded because we might want to run the systemcheck from the CLI before installing Piwik (which wasn't possible or documented, except that's how it's done in EnterpriseAdmin plugin so that's why it broke).
Given the plugin manager has been refactored for 2.14 I think the bug doesn't exist on master. However 2.13.1 is affected.
The text was updated successfully, but these errors were encountered:
When no config file exist (in the Plugin Manager):
This affects the loading of DI config (and maybe other things?): no plugin DI config is loaded. Additionally even when this is fixed, the Diagnostics plugin should always be loaded because we might want to run the systemcheck from the CLI before installing Piwik (which wasn't possible or documented, except that's how it's done in EnterpriseAdmin plugin so that's why it broke).
Given the plugin manager has been refactored for 2.14 I think the bug doesn't exist on master. However 2.13.1 is affected.
The text was updated successfully, but these errors were encountered: