Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console init failure when no config exist #7968

Closed
mnapoli opened this issue May 22, 2015 · 2 comments
Closed

Console init failure when no config exist #7968

mnapoli opened this issue May 22, 2015 · 2 comments
Assignees
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc.

Comments

@mnapoli
Copy link
Contributor

mnapoli commented May 22, 2015

When no config file exist (in the Plugin Manager):

$plugins = @Config::getInstance()->Plugins['Plugins'];
// $plugins is null
$this->makePluginsToLoad($plugins);
// null is passed in the parameter, the catchable fatal error is somehow silenced because suppressed
private function makePluginsToLoad(array $pluginsToLoad)
{
    $pluginsToLoad = array_unique($pluginsToLoad);
    // ... $pluginsToLoad stays null…
    return $pluginsToLoad; // returns NULL
}

This affects the loading of DI config (and maybe other things?): no plugin DI config is loaded. Additionally even when this is fixed, the Diagnostics plugin should always be loaded because we might want to run the systemcheck from the CLI before installing Piwik (which wasn't possible or documented, except that's how it's done in EnterpriseAdmin plugin so that's why it broke).

Given the plugin manager has been refactored for 2.14 I think the bug doesn't exist on master. However 2.13.1 is affected.

@mnapoli mnapoli added the Bug For errors / faults / flaws / inconsistencies etc. label May 22, 2015
@mnapoli mnapoli self-assigned this May 22, 2015
mnapoli added a commit that referenced this issue May 22, 2015
…ile doesn't exist + force always load the Diagnostics plugin to be able to run the system check any time
@mnapoli
Copy link
Contributor Author

mnapoli commented May 22, 2015

This is fixed in 6928474 in the version/2.13.2 branch, we'll probably need to tag a new release from that.

@mnapoli
Copy link
Contributor Author

mnapoli commented May 28, 2015

It seems the patch will be applied manually by the PRO team.

@mnapoli mnapoli closed this as completed May 28, 2015
@mattab mattab modified the milestone: Short term Sep 23, 2015
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants