Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hook to OptOut Action (CustomOptOut) #7962

Closed
Zeichen32 opened this issue May 21, 2015 · 5 comments
Closed

Add Hook to OptOut Action (CustomOptOut) #7962

Zeichen32 opened this issue May 21, 2015 · 5 comments
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@Zeichen32
Copy link
Contributor

Currently i need to copy the whole "OptOut Action" and logic to change the "OptOut View".
https://github.com/Zeichen32/PiwikCustomOptOut/blob/master/Controller.php#L108

I think, it would be a much cleaner way if we can trigger a event just befor the view is render to change the "OptOut View".
https://github.com/piwik/piwik/blob/master/plugins/CoreAdminHome/Controller.php#L362

If it is okay for you, I would like to work on a PR.

@mnapoli
Copy link
Contributor

mnapoli commented May 21, 2015

Out of curiosity what are you trying to achieve with your alternate view?

@Zeichen32
Copy link
Contributor Author

The CustomOptOut Plugin allows to style your optout iframe with custom css per site. To implement this feature i need edit the optout template.

@mnapoli
Copy link
Contributor

mnapoli commented May 22, 2015

Mmh right I see, it makes sense then, maybe others will have feedback on the idea?

@Zeichen32
Copy link
Contributor Author

I'm open for any suggestions and ideas.

@mattab
Copy link
Member

mattab commented Jun 24, 2015

Hi @Zeichen32 let's discuss in your PR #7979

@mattab mattab closed this as completed Jun 24, 2015
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

No branches or pull requests

3 participants