Injection Inception, Change #2: Adding Config to DI #7957
Conversation
diosmosis
added
c: Platform
| @@ -14,4 +14,5 @@ | |||
| 'Piwik\Translation\Translator' => DI\object() | |||
| ->constructorParameter('directories', array()), | |||
|
|
|||
| 'Piwik\Config' => DI\object('Piwik\Tests\Framework\Mock\TestConfig') | |||
There was a problem hiding this comment.
Could you add a trailing ,? 😉
|
By the way super easy to review by commit (especially since all commits but one are really simple to understand) 👍 |
…ment.php to the TestConfig class. Since this logic is meant to be executed directly after a Config instance is created, and is only used when TestConfig is used, we can do this.
…in Config.php. Also removed the $initialized property, which is only used to lazily post the test event.
…anging some non-pro plugins when merged (LoginLdap only I think).
diosmosis
force-pushed
the
test_env_di_3
branch
2 times, most recently
from
44b8285
to
ccf9c12
Compare
|
Finished up the PR, build is passing except for one system test. No idea why it's failing, when I tried to debug it went away. Seems to be random. |
diosmosis
removed
the
Pull Request WIP
I notice there are some failures that are not random eg. For the random build issue, can you create an issue? (everyone in the team will know that this test result could randomly fail) |
…rough DI config. Replaced the singleton GlobalSettingsProvider hack w/ the concept of an EnvironmentManipulator (internal to Piwik, not to be used anywhere but TestingEnvironment.php).
…vironmentManipulators, don't use custom config files in AssetManagerTest. This includes using custom logic for testing if a plugin is core (since we can't change global.ini.php contents).
…w, and setting config must be done after environment is created.
…ing fails because the environment has not been created yet. Fixes EnvironmentValidationTest. Includes new exception thrown when StaticContainer cannot find an existing container.
Adding Config instance to DI and move all Config related test setup code from Config.php and TestingEnvironment.php to TestConfig class. Introduced completely internal EnvironmentManipulator concept so tests can change paths of local/global/common INI config file.
This PR adds the Config singleton to DI (removing the use of the singleton). Additional changes include:
Note: tests won't pass, I need to fix them and include the changes in the correct commits.