Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add php cs fixer #7955

Closed
wants to merge 5 commits into from
Closed

Add php cs fixer #7955

wants to merge 5 commits into from

Conversation

fabiocarneiro
Copy link
Contributor

Fixes #7186

I saw that there is already a PR for that, but was created 1 month ago. Its taking ~117 seconds to run, and it is reporting 326 failures.

I had to update the dependencies to include php-cs-fixer. Here is a list of what was modified.

  - Removing myclabs/php-enum (1.3.2)
  - Removing twig/twig (v1.18.0)
  - Installing twig/twig (v1.18.1)
    Downloading: 100%         

  - Removing monolog/monolog (1.12.0)
  - Installing monolog/monolog (1.13.1)
    Downloading: 100%         

  - Removing symfony/monolog-bridge (v2.6.3)
  - Installing symfony/monolog-bridge (v2.6.7)
    Downloading: 100%         

  - Removing sebastian/version (1.0.4)
  - Installing sebastian/version (1.0.5)
    Loading from cache

  - Removing sebastian/environment (1.2.1)
  - Installing sebastian/environment (1.2.2)
    Loading from cache

  - Removing sebastian/diff (1.2.0)
  - Installing sebastian/diff (1.3.0)
    Loading from cache

  - Removing symfony/yaml (v2.6.3)
  - Installing symfony/yaml (v2.6.7)
    Loading from cache

  - Installing phpdocumentor/reflection-docblock (2.0.4)
    Loading from cache

  - Installing phpspec/prophecy (v1.4.1)
    Downloading: 100%         

  - Removing phpunit/phpunit-mock-objects (2.3.0)
  - Installing phpunit/phpunit-mock-objects (2.3.1)
    Loading from cache

  - Removing phpunit/php-token-stream (1.4.0)
  - Installing phpunit/php-token-stream (1.4.1)
    Loading from cache

  - Removing phpunit/php-file-iterator (1.3.4)
  - Installing phpunit/php-file-iterator (1.4.0)
    Loading from cache

  - Removing phpunit/php-code-coverage (2.0.15)
  - Installing phpunit/php-code-coverage (2.0.16)
    Loading from cache

  - Removing phpunit/phpunit (4.4.5)
  - Installing phpunit/phpunit (4.6.6)
    Downloading: 100%         

  - Removing phpseclib/phpseclib (0.3.9)
  - Installing phpseclib/phpseclib (0.3.10)
    Downloading: 100%         

  - Removing symfony/var-dumper (v2.6.3)
  - Installing symfony/var-dumper (v2.6.7)
    Downloading: 100%         

  - Removing doctrine/annotations (v1.2.3)
  - Installing doctrine/annotations (v1.2.4)

  - Removing doctrine/cache (v1.4.0)
  - Installing doctrine/cache (v1.4.1)
    Loading from cache

  - Removing pear/archive_tar (1.3.15)
  - Installing pear/archive_tar (1.3.16)
    Downloading: 100%         

  - Removing symfony/event-dispatcher (v2.6.3)
  - Installing symfony/event-dispatcher (v2.6.7)
    Downloading: 100%         

  - Removing guzzle/guzzle (v3.9.2)
  - Installing guzzle/guzzle (v3.9.3)
    Loading from cache

  - Installing php-di/invoker (1.0.0)
    Downloading: 100%         

  - Installing symfony/stopwatch (v2.6.7)
    Downloading: 100%         

  - Installing symfony/process (v2.6.7)
    Downloading: 100%         

  - Installing symfony/finder (v2.6.7)
    Downloading: 100%         

  - Installing symfony/filesystem (v2.6.7)
    Downloading: 100%         

  - Removing symfony/console (v2.6.3)
  - Installing symfony/console (v2.6.7)
    Loading from cache

  - Installing fabpot/php-cs-fixer (v1.8)
    Downloading: 100%         

  - Installing doctrine/annotations (v1.2.4)
    Downloading: 100%         

  - Updating mnapoli/php-di 5.0.x-dev (b555566 => 7afd257)
    Checking out 7afd2574c3f4c23814a43dbca23d7cd1741aa489

@mattab
Copy link
Member

mattab commented May 21, 2015

Hi @fabiocarneiro

Thanks for PR. as you write there is already a PR for this, is there particular reason you create another one? #7731

@fabiocarneiro
Copy link
Contributor Author

@mattab The other one seems not to be running on travis. These tests take almost two minutes to run. Since piwik has 7 jobs, it will add 14 minutes on the testing avg run time.

I don't know if the testing env currently allows that, but it would be nice to create a new job that doen't run anything, but this. So it will be 2 minutes instead of 14. What do you think?

@tsteur
Copy link
Member

tsteur commented May 24, 2015

Is it possible to execute it only with one job instead of each time again? Maybe we could run it with the Unit Tests on PHP 5.6 or so?

@mattab mattab mentioned this pull request Jun 25, 2015
Closed
@ThaDafinser ThaDafinser mentioned this pull request Sep 3, 2015
Closed
@mattab
Copy link
Member

mattab commented Sep 8, 2015

Hi there, feel free to continue discussion in this other pull request: #8704

@mattab mattab closed this Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabiocarneiro @mattab @tsteur