Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed inconsistencies of widget styling #7950

Merged
merged 1 commit into from May 21, 2015
Merged

Removed inconsistencies of widget styling #7950

merged 1 commit into from May 21, 2015

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented May 20, 2015

Fixes #7879

I refactored less rules for widgets into a new widget.less file in the Dashboard plugin that contains rules that I moved from Dashboard, Morpheus, Zen mode, …

@mnapoli mnapoli added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels May 20, 2015
@mnapoli mnapoli added this to the 2.14.0 milestone May 20, 2015
@mnapoli mnapoli mentioned this pull request May 20, 2015
Closed
@mnapoli mnapoli added the Needs Review PRs that need a code review label May 20, 2015
@tsteur
Copy link
Member

tsteur commented May 20, 2015

👍 looks good to me.

There are a couple of broken UI test but they might be not caused by this change eg
http://builds-artifacts.piwik.org/ui-tests.fix-widgets-design/12627.7/screenshot-diffs/singlediff.html?processed=../processed-ui-screenshots/UIIntegrationTest_admin_plugin_settings.png&expected=UIIntegrationTest_admin_plugin_settings.png&github=UIIntegrationTest_admin_plugin_settings.png where the blue help boxes are quite small now and http://builds-artifacts.piwik.org/ui-tests.fix-widgets-design/12627.7/screenshot-diffs/singlediff.html?processed=../processed-ui-screenshots/CoreUpdaterCode_newVersion.png&expected=CoreUpdaterCode_newVersion.png&github=CoreUpdaterCode_newVersion.png shows update to 4.0.0? It is certainly not caused by this one but was wondering whether 4.0.0 is hard coded in the HTML or in the UI test?

@mnapoli
Copy link
Contributor Author

mnapoli commented May 21, 2015

The 4.0.0 version is the UpdaterMock that simulates a new version available (I chose this version number because it should always work right ;))

The UI tests fails are not related (same on master).

mnapoli added a commit that referenced this pull request May 21, 2015
@mnapoli
Merge pull request #7950 from piwik/fix-widgets-design
6bf528f 
Removed inconsistencies of widget styling
@mnapoli mnapoli merged commit 6bf528f into master May 21, 2015
@mnapoli mnapoli deleted the fix-widgets-design branch May 21, 2015 06:10
This was referenced Jul 31, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mnapoli @tsteur