Handle correctly URLs with utf8 characters (Outlinks and Download URLs) #7944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orks with utf-8 characters Previously was using unescape which did not work well with utf8 non ascii characters.
mattab
added
the
Pull Request WIP
Conflicts: piwik.js
It was modified twice today and got a merge conflict
mattab
added
not-in-changelog
mattab
pushed a commit
that referenced
this pull request
May 22, 2015
Handle correctly URLs with utf8 characters (Outlinks and Download URLs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously was using unescape which did not work well with utf8 non ascii characters.
WIP as I need to check if tests still pass
Fixes #5014