Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect screen resolution detection for devices with device pixel ratio > 1 #7942

Merged
merged 1 commit into from May 19, 2015
Merged

Fix incorrect screen resolution detection for devices with device pixel ratio > 1 #7942

merged 1 commit into from May 19, 2015

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 19, 2015

take device pixel ratio always into account when detecting screen resolution

(fixes #7941)

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 19, 2015
@mattab
Copy link
Member

mattab commented May 19, 2015

Looks good!

mattab pushed a commit that referenced this pull request May 19, 2015
Merge pull request #7942 from piwik/resolution_fix
5fa7055 
Fix incorrect screen resolution detection for devices with device pixel ratio > 1
@mattab mattab merged commit 5fa7055 into master May 19, 2015
@mattab mattab added this to the 2.14.0 milestone May 19, 2015
@mnapoli mnapoli deleted the resolution_fix branch May 20, 2015 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @mattab