Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect screen resolution detected for devices with device pixel ratio > 1 #7941

Closed
dandv opened this issue May 19, 2015 · 5 comments
Closed

Incorrect screen resolution detected for devices with device pixel ratio > 1 #7941

dandv opened this issue May 19, 2015 · 5 comments
Assignees
@sgiehl
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc.
Milestone
Backlog (Help wan...

Comments

@dandv
Copy link
Contributor

dandv commented May 19, 2015

Possible follow-up to #3962. I'm a new Piwik user and had disabled the UserSettings plugin.

image

My device is a Samsung Galaxy S5 and the actual resolution is 1080 x 1920.
@tsteur
Copy link
Member

tsteur commented May 19, 2015

Which Piwik version are you using? The UserSettings plugin is "outdated" and replaced by different plugins such as "Resolution", "DevicesDetection" etc. Which Piwik version are you using?

I presume you are tracking a website and not an Android App?

@dandv
Copy link
Contributor Author

dandv commented May 19, 2015

I'm a new user so the latest Piwik, 2.13.1. I'm tracking http://idorecall.com.

UserSettings is inactive.
DevicesDetection and Resolution are active.

@tsteur
Copy link
Member

tsteur commented May 19, 2015

Thx! Just one more question from my site (@sgiehl might have some more questions): Does it maybe say which device etc was detected?

@dandv
Copy link
Contributor Author

dandv commented May 19, 2015

The screenshot shows "Android 4.4". Should I look elsewhere?

@sgiehl
Copy link
Member

sgiehl commented May 19, 2015

That might be a general problem with devices having a device pixel ratio > 1. Just had a look with my Nexus 5. Piwik reports 360x640, aswell. The Nexus 5 has a device pixel ratio of 3. We already have a special handling for macs, guess that should be enhanced to be valid for mobile devices, aswell. See https://github.com/piwik/piwik/blob/master/js/piwik.js#L4025-L4059

@sgiehl sgiehl added the Bug For errors / faults / flaws / inconsistencies etc. label May 19, 2015
@sgiehl sgiehl changed the title Incorrect screen resolution detected on Chrome on Android Incorrect screen resolution detected for devices with device pixel ratio > 1 May 19, 2015
@sgiehl sgiehl self-assigned this May 19, 2015
sgiehl added a commit that referenced this issue May 19, 2015
@sgiehl
fixes #7941 - take device pixel ratio into account when detecting scr…
a860495 
…een resolution
@sgiehl sgiehl mentioned this issue May 19, 2015
Merged
sgiehl added a commit that referenced this issue May 19, 2015
@sgiehl
fixes #7941 - take device pixel ratio into account when detecting scr…
2d80649 
…een resolution
@mattab mattab modified the milestone: Short term Sep 23, 2015
@mattab mattab added answered For when a question was asked and we referred to forum or answered it. and removed answered For when a question was asked and we referred to forum or answered it. labels Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
4 participants
@dandv @tsteur @mattab @sgiehl