Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for URL garbage issue #7939

Closed

Conversation

saleemkce
Copy link
Contributor

updated fix.

@mattab
Copy link
Member

mattab commented May 20, 2015

Hi @saleemkce

Thanks for the pull request. I tested it using the script to reproduce the issue: #5014 (comment)

but unfortunately the URL still appears with wrong characters:
wrong chars

Note that Thomas even posted the solution earlier in: #5014 (comment)

therefore i'm closing this PR and we will fix it soon

@mattab mattab closed this May 20, 2015
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label May 20, 2015
@mattab
Copy link
Member

mattab commented May 20, 2015

@saleemkce my attempt at fixing the issue: https://github.com/piwik/piwik/pull/7944/files

@saleemkce
Copy link
Contributor Author

@mattab did you look at the conversation between me and Thomas #7866 (comment)? There is an issue in js/piwik.js line no.3314 in my changed files. Please go through this page and see some bug issues fixed here.

@mattab
Copy link
Member

mattab commented May 20, 2015

@saleemkce sorry I didn't look at the conversation, somehow I missed it. I just tested both cases:

 <a target="_blank" href="http://example.org/2013/06/test.php?param[]=1&test2=%D8%A5%D9%86%D8%B4%D8%A7%D8%A1-%D9%86%D8%B3%D8%AE%D8%A9-%D9%85%D8%AE%D8%B5%D8%B5%D8%A9-%D9%86%D8%B8%D8%A7%D9%85-%D8%AA%D8%B4%D8%BA%D9%8A%D9%84-%D8%A3%D9%8$

2nd link

 <a target="_blank" href="http://example.org/2013/06/إنشاء-نسخة-مخصصة-نظام-تشغيل-أوبنتو-ب">test with actualy Url utf8</a>

and both cases worked in the new PR #7944 so maybe that's a good solution?

@saleemkce
Copy link
Contributor Author

@mattab oh that's great. Please commit your fix. I will later do so more testing in this and report you if anything goes wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants