New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Widgets API for plugins #7927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent this case we call `checkIsEnabled` in Controller. Also has the advantage that we always can get a requested instance even if not enabled which is good
…o change everything, eg order
…k for valid config if dev mode is enabled
…ted strings later
@@ -341,21 +348,69 @@ public function render() | |||
return $rendered; | |||
} | |||
|
|||
protected function createWidget() | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't care about code in this class for now. This will be completely changed in #7822
mattab
added
the
Pull Request WIP
Indicates the current pull request is still work in progress and not ready yet for a review.
label
May 19, 2015
Merged it into that branch for now as I need it there and noticed I can remove a couple of things afterwards. Eg the static method |
mattab
added
the
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
label
Jun 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Review
PRs that need a code review
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
Pull Request WIP
Indicates the current pull request is still work in progress and not ready yet for a review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #7861
This is a PR just to collect feedback. Please don't merge for now. It's a bit hard to explain for now but it'll make more sense after also having more code in #7822
For more information see #7861
This code will be used in Piwik 3.0. We don't need to care about BC but this code is BC for now.
Now a widget will be basically configured like this:
WidgetConfig can be also used in a
WidgetsList.addWidgets
event (although this is currently deprecated)And it will be probably used in reports to create a widget from a report eg