Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step "Create tables" of new installation appears untranslated #7926

Closed
PatchRanger opened this issue May 17, 2015 · 3 comments
Closed

Step "Create tables" of new installation appears untranslated #7926

PatchRanger opened this issue May 17, 2015 · 3 comments
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.15.0

Comments

@PatchRanger
Copy link

How to reproduce

Initialize a new installation of Piwik, follow the installation steps. On "Database setup" step, fill in the form with new table prefix in order to get the use-case of "tablesCreated".

Expected result

The layout of the page and the message are fully translated to the current language.

Real result

Everything from layout to appeared message (which is successful, sic) are in English, though all steps before and even after it are localized.
@sgiehl
Copy link
Member

sgiehl commented May 17, 2015

I can reproduce that. Not sure why the translations are not used even if they are available.

@sgiehl sgiehl added the Bug For errors / faults / flaws / inconsistencies etc. label May 17, 2015
@PatchRanger
Copy link
Author

After debugging a little, I've discovered that for that page Translator, returned by StaticContainer, has a private property currentLanguage set to en, though it's not the case for other pages.

PatchRanger added a commit to PatchRangerTempStorage/piwik that referenced this issue May 29, 2015
@PatchRanger
Fix matomo-org#7926: Correct default language
76542aa
@PatchRanger PatchRanger mentioned this issue May 29, 2015
Closed
@mattab mattab added this to the 2.15.0 milestone Jul 15, 2015
@mnapoli
Copy link
Contributor

mnapoli commented Jul 27, 2015

For the record, PR WIP: #8022

@tsteur tsteur self-assigned this Aug 6, 2015
tsteur added a commit that referenced this issue Aug 6, 2015
@tsteur
Step "Create tables" of new installation appears untranslated
791ca9d 
fixes #7926
@tsteur tsteur mentioned this issue Aug 6, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
5 participants
@tsteur @mattab @mnapoli @sgiehl @PatchRanger