Bugfix updated url garbled #7917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @saleemkce - as you can see there are like 10 commits in this PR. My suggestion was that there should be only one commit per PR to keep it clean. Can you try again and make it only one commit. If you struggle with Git, I can recommend using Phpstorm which makes it a bit easier as it makes GIT operations visual. |
saleemkce
force-pushed
the
bugfix-updated-url-garbled
branch
2 times, most recently
from
894bb97
to
113f21a
Compare
language update Do not display the visitor profile to anonymous users since it requires using a segment that cannot be used by the anonymous user. remove old tcpdf require tcpdf using composer remove require as that is handled by composer now adjusted tcpdf path use correct fonts for special languages Fixes matomo-org#7815 Test for commands sooner to avoid error messages fix for URL garbage issue
saleemkce
force-pushed
the
bugfix-updated-url-garbled
branch
from
113f21a
to
1a2eb65
Compare
|
@mattab @tsteur Currently, I don't have access to PHPStrom, I am using Submile Text 2. But, I have managed to do it right after numerous attemps (effort taken to fix this git files issue is more than actual bugfix -:) ) Checkout here: #7939 If anything is wrong, please let me know. If this commit is correct, please do merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new PR for URL garbled issue. with only 2 changed files.