Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require TCPDF using composer #7908

Merged
merged 5 commits into from May 19, 2015
Merged

Require TCPDF using composer #7908

merged 5 commits into from May 19, 2015

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 14, 2015

TCPDF is available using composer. That will allow us to easily update it.
There is already a newer version available.

Is there a reason why we didn't switch that earlier?

I've also checked the pdf reports for problematic languages (refs #1907).
Only Telugu seems not to work with any of the bundled fonts. Hindi, Bengali, Amharic, Tamil and Thai are working now :) (But the text in some of the rendered charts still doesn't)

@sgiehl sgiehl added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. RFC Indicates the issue is a request for comments where the author is looking for feedback. labels May 14, 2015
@mattab
Copy link
Member

mattab commented May 15, 2015

👍

fyi: there were a couple mods we had to make to TCPDF and not sure if they made the change upstream, maybe we could check changesets linked in https://github.com/piwik/piwik/blob/master/libs/README.md#L22-25

@sgiehl
Copy link
Member Author

sgiehl commented May 15, 2015

The changes we made didn't exactly made it upstream, but there were many parts of tcpdf changed. Maybe some of the changes also fixed those problems.
As our changes were just minor, maybe we should just try to use the new version. If those errors occur again, maybe we can find another solution, or create a PR for tcpdf to fix it.
All tests are still passing, and as far as I have tested various pdf reports in different languages, there were no errors.
I'll do some more testing later...

@mattab
Copy link
Member

mattab commented May 19, 2015

As our changes were just minor, maybe we should just try to use the new version. If those errors occur again, maybe we can find another solution, or create a PR for tcpdf to fix it.

Alright! could you merge this soon and we can publish a new beta? hopefully we would catch any obvious bug with an early beta.

@mattab mattab added this to the 2.14.0 milestone May 19, 2015
@sgiehl sgiehl removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. RFC Indicates the issue is a request for comments where the author is looking for feedback. labels May 19, 2015
sgiehl pushed a commit that referenced this pull request May 19, 2015
Require TCPDF using composer
@sgiehl sgiehl merged commit 06ebc8b into master May 19, 2015
@sgiehl sgiehl deleted the tcpdf_composer branch May 19, 2015 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants