New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require TCPDF using composer #7908
Conversation
👍 fyi: there were a couple mods we had to make to TCPDF and not sure if they made the change upstream, maybe we could check changesets linked in https://github.com/piwik/piwik/blob/master/libs/README.md#L22-25 |
The changes we made didn't exactly made it upstream, but there were many parts of tcpdf changed. Maybe some of the changes also fixed those problems. |
Alright! could you merge this soon and we can publish a new beta? hopefully we would catch any obvious bug with an early beta. |
TCPDF is available using composer. That will allow us to easily update it.
There is already a newer version available.
Is there a reason why we didn't switch that earlier?
I've also checked the pdf reports for problematic languages (refs #1907).
Only Telugu seems not to work with any of the bundled fonts. Hindi, Bengali, Amharic, Tamil and Thai are working now :) (But the text in some of the rendered charts still doesn't)