Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visitorlog: Use a tooltip to display additional information to avoid text truncation #7907

Merged
merged 1 commit into from May 14, 2015

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 14, 2015

To avoid text truncation for showing more details when hovering the icons, I've switched to tooltips.
That way the information will always be visible completely.

image

Not sure if that is better that way.
Nevertheless I think the visitor log needs a complete redesign.

refs #7812

@sgiehl sgiehl added the Needs Review PRs that need a code review label May 14, 2015
@mattab mattab added this to the 2.14.0 milestone May 14, 2015
mattab pushed a commit that referenced this pull request May 14, 2015
Visitorlog: Use a tooltip to display additional information to avoid text truncation
@mattab mattab merged commit 9912123 into master May 14, 2015
@mattab
Copy link
Member

mattab commented May 14, 2015

Lgtm, further suggestions:

  • plugin icons that don't look so good on black background... maybe we display the text label of plugins instead?
  • make the tooltip inner text same font size as standard text. Currently it is smaller which can make tooltip difficult to read (grey on black also has lower contrast)

(later hopefully we will use tooltips that make content copy-pastable as nice UIs let users copy paste the visible data)

@sgiehl sgiehl deleted the visitorlogdetails branch May 15, 2015 17:50
@sgiehl sgiehl removed the Needs Review PRs that need a code review label May 24, 2015
@sgiehl sgiehl mentioned this pull request Jun 6, 2015
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants