Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New design for buttons #7896

Merged
merged 9 commits into from Jun 1, 2015
Merged

New design for buttons #7896

merged 9 commits into from Jun 1, 2015

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented May 13, 2015

ref #7585

  • applied small design changes that were in the redesign mockups for buttons (e.g. small shadow, …)
  • simplified the Less rules, e.g. removed usage of !important which was making it very hard to customize the look of buttons in more specific places
  • removed custom buttons styles to make buttons consistent in Piwik (it was mostly the date selector which had a slightly smaller button, I don't think there was another one…)
  • put button styles in _buttons.less (were previously in _forms.less)
  • links in the admin are now the same color as everywhere else in Piwik (blue instead of black)

I will update the description with screenshots once the UI tests have finished.

@mnapoli mnapoli added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels May 13, 2015
@mnapoli mnapoli added this to the 2.14.0 milestone May 13, 2015
@mnapoli mnapoli mentioned this pull request May 13, 2015
Merged
@mattab
Copy link
Member

mattab commented May 13, 2015

Found couple regressions:

Once fixed feel free to merge 👍

@mnapoli mnapoli added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. and removed Needs Review PRs that need a code review labels May 14, 2015
@mnapoli
Copy link
Contributor Author

mnapoli commented May 14, 2015

Thx I realize I shouldn't have used the "needs review" label directly, for the PRs I've opened lately I was waiting for the UI tests to run to fix possible regressions (haven't had a look at the results yet). Will fix and re-add for review when all is good.

@mattab
Copy link
Member

mattab commented May 14, 2015

oops I pushed by mistake the submodule update for expected screenshot in this branch. My bad... git-lfs will be awesome!

@mnapoli mnapoli mentioned this pull request May 21, 2015
Closed
@mnapoli mnapoli force-pushed the redesign-buttons branch 3 times, most recently from 0bce220 to 201d35f Compare May 21, 2015 14:08
@mnapoli
Copy link
Contributor Author

mnapoli commented May 21, 2015

Note to self: sitemanager buttons http://builds-artifacts.piwik.org/ui-tests.redesign-buttons/12671.7/screenshot-diffs/diffviewer.html

mnapoli added a commit that referenced this pull request May 31, 2015
@mnapoli
#7896 fix small UI regression following the redesign of buttons
6eb3fc0
mnapoli added a commit that referenced this pull request May 31, 2015
@mnapoli
#7896 fix small UI regression following the redesign of buttons
e6838fa
@mnapoli mnapoli force-pushed the redesign-buttons branch 2 times, most recently from 6eb3fc0 to 159c00c Compare May 31, 2015 17:54
mnapoli added a commit that referenced this pull request May 31, 2015
@mnapoli
#7896 fix small UI regression following the redesign of buttons
159c00c
@mnapoli mnapoli mentioned this pull request May 31, 2015
Merged
@mnapoli mnapoli added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Jun 1, 2015
@mnapoli
Copy link
Contributor Author

mnapoli commented Jun 1, 2015

Finally ready for review \o/

@diosmosis
Copy link
Member

Looks ok to merge, requires a rebase first, though.

@mnapoli
Copy link
Contributor Author

mnapoli commented Jun 1, 2015

Rebased!

diosmosis added a commit that referenced this pull request Jun 1, 2015
@diosmosis
Merge pull request #7896 from piwik/redesign-buttons
735eceb 
Introduce new consistent design for buttons through 'btn' CSS class.
@diosmosis diosmosis merged commit 735eceb into master Jun 1, 2015
@diosmosis diosmosis deleted the redesign-buttons branch June 1, 2015 22:01
diosmosis pushed a commit that referenced this pull request Jun 2, 2015
Updating expected UI screenshots for #7896 merge.
88d7fa8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mnapoli @mattab @diosmosis