Game of Containers: Step 2 - Application encapsulation #7888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
the
Pull Request WIP
…capsulate tracker entry point in new TrackerApplication class.
|
Can this PR be closed? |
|
No, I've still got work to do on it, but I've moved it to the 3.0 milestone. If you think it's not needed, though, let me know. |
|
Ah ok sorry I thought it was in review and I thought it was something already implemented in other PRs but I'm mistaken ;) |
|
closing this issue for now. We may continue on this change for Piwik 3 but we'll need to make the changes based on 3.x-dev branch when needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, more to come later...
Winter is coming.