Getting Piwik to work on IE8 again by fixing a couple issues in various JS files. #7886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us JS files. Specifically, avoid using catch/delete methods/properties directly, instead access via strings.
diosmosis
added a commit
that referenced
this pull request
May 12, 2015
Getting Piwik to work on IE8 again by fixing a couple issues in various JS files. Some JS files use .catch( methods and .delete properties which IE8 chokes on. Changed to access via strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some JS files use
.catch(methods and.deleteproperties which IE8 chokes on. Changed to access via strings.