Most of the graph UI tests seem to be broken?

Shouldn't there be maybe a $this->requestConfig->disable_queued_filters = 1 somewhere? If all the graphs still work, was it maybe for performance reasons? I think you added this line originally as Fixes #4429, allow processed columns to be sorted in table visualizations.

If the queued filters are for processed metrics, then they shouldn't be necessary anymore... I'll look at the test failures.

The graph UI tests pass, are you looking at the right build?

I looked at the linked travis build: https://travis-ci.org/piwik/piwik/jobs/62025592

It says quite often eg

  6) ReportExporting should export an evolution graph report correclty when the CSV export link is clicked:
     No expected output file found at /home/travis/build/piwik/piwik/tests/lib/screenshot-testing/../../../tests/UI/./expected-ui-screenshots/ReportExporting_VisitsSummary.get_exported.csv.txt.
       Url to reproduce: http://localhost/tests/PHPUnit/proxy/?module=Widgetize&action=iframe&idSite=1&period=year&date=2012-08-09&isFooterExpandedInDashboard=1&moduleToWidgetize=VisitsSummary&actionToWidgetize=get&viewDataTable=graphEvolution

Probably master needs to update submodule to expected screenshots?

Those are tests for the export links; they need expected output. I was going to put them in after the merge. Otherwise I can create a branch on the ui screenshot repo, but then the merge will have to be done from the command line.

Cool, thought so. For new files I usually add them directly in master branch of screenshot repo as they won't break existing tests. This makes tests green as we'd add them afterwards anyway (unless PR is not merged but that's rare). Branch is certainly not needed. OK to put in after merge

@tsteur See any reason not to merge? Otherwise I will merge & update the expected test files.

Good to merge if it works. I was a bit worried re queued filters and performance regression but doubt it will cause any.