Visit Overview (with graph) widget targets correct graph #7872
Conversation
|
I just tested it and noticed one problem. Eg when you select a different metric in "Visits Overview (with graph)" it will reload the widget with the headline again, resulting the headline to be shown twice:
That's why it currently calls The problem is that the index action will render the headline again. It's a bit weird behaviour that we do not replace the previous headline and hope we can fix this in a future version. Maybe while working on #7822 Maybe we need another method in that controller that basically just forwards everything to |
|
Ah, good catch! I've added another method as you suggested, and think this is a pretty good interim solution. Also added a few comments to help make everything clear. It seems to replace the headline, https://github.com/piwik/piwik/blob/master/plugins/CoreHome/javascripts/dataTable.js#L262 would need to check for an existing headline and remove it if necessary—I'm new to this project, so not sure if that would run in to any problems. #7822 mentions an AngularJS layout for pages which would change all this anyway :) |
|
Looks good to merge to me. Would you just mind to replace each tab with 4 whitespaces? |
|
Sure thing! |
|
Thx for that! Great to see this fixed. |
…rong_graph Visit Overview (with graph) widget targets correct graph
mattab
added
the
answered
"Visit Overview (with graph)" and "Visits Over Time" widgets use the same action name when calling
getLastUnitGraphAcrossPlugins, which can lead to "Visit Overview (with graph)" targeting the wrong graph when clicking on one of the metrics listed under "Report". This not only leads to the scrolling behavior described in #7086, but it also updates the wrong graph!By adding an optional parameter to the
getEvolutionGraphmethod, the actual calling action can be specified. In this case, by passing through the "index" action name, "Visits Overview (with graph)" can be distinguished from "Visits Over Time".