New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proof of concept fix for history plugin's scroll to top issue #7869
Conversation
I just had a quick look. Could you please have a look at the popovers again. |
@sgiehl There was a |
Cool, have you tried it in all the browsers? Especially older ones like IE8? I had a quick look in latest Chrome on Mac and somehow I got this error in the console:
What I did to reproduce was I went to the |
It's possible, the problem is when invoking angular from broadcast we need I haven't checked every browser, but I'll look into it soon. |
I think there are ways to avoid this error see eg the linked StackOverflow link. Would be great to avoid that JS error. If that solution works it would be cool and a first start to replace |
c36a3cc
to
b6e564b
Compare
Tested on the following browsers: Ubuntu:
Windows:
OS X:
Appears to work in every case. The PR is ready for another review and/or merge. Note: I moved the |
Looks good to me code wise, not sure if I tested all cases. |
…ssue. Fix involves using angular service that uses the singleton instead of jquery's history plugin. Can remove the history plugin after this change.
…le after modifying (through the history service), hide error in anchorLinkFix code if hash is not valid element selector, and use .path to push new history items.
…ating new digest cycle to avoid digest already in progress error.
…ethod (which is not available).
b6e564b
to
f2b5cb3
Compare
Fixes #7798 use angular.js $location object to change current page instead of jquery history plugin. Includes new angular service that manipulates $location object and invokes old broadcast object. jquery history plugin is removed.
Fix involves using a new angular service that uses the
$location
singleton instead of jquery's history plugin.If this is acceptable, we can remove the history plugin after this change.
Note: I haven't tested every hash change use case, but the following works:
Refs #7798