Maybe it would make sense to extract that somewhere global and to reuse it whereever the request method is checked like https://github.com/piwik/piwik/blob/master/core/Tracker.php#L244-L248 or https://github.com/piwik/piwik/blob/master/plugins/Annotations/Controller.php#L109 and so on

@sgiehl we would benefit from a Request object with those kind of basic methods (e.g. 1 or 2), maybe this should be a longer-term refactoring thing?

I thought about this as well but noticed there were no other checks for GET. There were 2 or 3 more cases where a check for POST was done though. The code for this was already in that class anyway so it didn't make anything worse and was ok for me to reuse that existing bit for what we want to achieve. A new class or lib for this would certainly make sense but also requires quite a bit of work (investigating for a good lib to use etc). If we ever use another HTTP client lib it might come out of the box with it etc. Currently, I don't think it's worth the effort or the time spent is better somewhere else but can do if you think so.

I agree you shouldn't bother with that in the PR. Probably later PSR-7 would stand up as the obvious solution (the PSR will be accepted soon).

sounds good!