Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All Websites dashboard shows only the first 50 websites #7854

Closed
twodrunkbots opened this issue May 7, 2015 · 6 comments
Closed

All Websites dashboard shows only the first 50 websites #7854

twodrunkbots opened this issue May 7, 2015 · 6 comments
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.14.0

Comments

@twodrunkbots
Copy link

Hi

After the update from 2.12.1 to 2.13.0, the All Websites dashboard shows only the first 50 websites.
I have updated to 2.13.1 this morning and it's still the same:
If I click on "next" the dashboard shows nothing. (It should show the websites 50-99)

2mcecek

After some research I think I found the bug. Or, not the bug itself, but where the bug is:
In the controller of the MultiSites plugin i changed the following line:

Line 56: $limit = Common::getRequestVar('filter_limit', 0, 'int');
to
Line 56: $limit = 200;

And now the All Websites dashboard shows the first 200 websites.
So I think there is a problem with the GET parameter.

Have a nice day
Steven
@airandony
Copy link

Thanks you have fixed my problem !

@tsteur
Copy link
Member

tsteur commented May 7, 2015

How many websites do you have in your installation? Which browser are you using?

Have you configured any value for all_websites_website_per_page or site_selector_max_sites in your config/config.ini.php?

@airandony
Copy link

I have 63 websites. I'm also using the WebsiteGroups (v0.1.3) plugin.
I'm using the new version of Firefox on Mac OS Yosemite
No, I didn't change anything in config.ini.php.

@tsteur
Copy link
Member

tsteur commented May 8, 2015

Do you mind asking those questions? How many websites have you added to a group approx? And how many groups do you have approx?

Will help me to reproduce.

@airandony
Copy link

The problem is since the version 2.13.0. And we go on the second page, the second batch of websites is not showing up.
Here are a screenshot of my 13 groups and between 2 websites to 17.

@tsteur
Copy link
Member

tsteur commented May 10, 2015

Thanks a lot, I can reproduce it!

@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label May 10, 2015
@tsteur tsteur added this to the 2.14.0 milestone May 10, 2015
@tsteur tsteur self-assigned this May 10, 2015
tsteur added a commit that referenced this issue May 11, 2015
@tsteur
refs #7854 make sure to apply the limit filter on sites and groups, m…
fd88b28 
…ake dashboard much faster, and show the correct number of available sites
@tsteur tsteur mentioned this issue May 11, 2015
Merged
diosmosis added a commit that referenced this issue May 12, 2015
@diosmosis
Merge pull request #7877 from piwik/7854
d7b7fa2 
Fixes #7854, make sure to apply the limit filter on sites in groups instead of just groups and top level sites in all website dashboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
3 participants
@tsteur @airandony @twodrunkbots