Average order value graph does not display any data #7852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
| $metricsToAdd = $avgOrder->getDependentMetrics(); | ||
| $requestedColumns = array_unique(array_merge($requestedColumns, $metricsToAdd)); | ||
| } | ||
|
|
There was a problem hiding this comment.
This logic should be handled by the Report::getMetricsRequiredForReport() call below, is there a reason it isn't?
There was a problem hiding this comment.
Nevermind I see my comment below about this.
|
Should there be a new test for this? Existing tests don't change, so I assume this code path isn't being tested. |
|
Added a test |
diosmosis
added a commit
that referenced
this pull request
May 8, 2015
Fixes #7851, fix average order value graph does not display any data. If average_order_value is requested by itself, dependent metrics are not requested as well because logic is done manually in API method, not in Report infrastructure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7851
There were 2 problems:
avg_order_revenuedepends onrevenueandconversion_ratebut when selectingavg_order_revenueonly that metric was fetched, the dependent ones were not fetchedavg_order_revenuewas formatted eg to$ 12.04which resulted in0when converting to float.