update pchart library from 2.1.3 to 2.1.4 and moved them to a new folder #7844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While having a look at this PR https://github.com/piwik/piwik/pull/7660/files I noticed there is an update available for pchart (since Jan 2014). It fixes eg a labelling bug on the pie charts and adds a feature re opacity.
I also moved the files to another folder as it included the version number before. This should not have an impact re breaking things but I could re-add the old files again into the libs folder till Piwik 3.0.0
There is a package for pchart on packagist/composer but those are all forks and initially we said we will only use composer for repositories that are maintained by the author of the lib.
I did a diff between 2.1.3 and 2.1.4 to see if we applied any patches in the past and to do a quality/security review of the patches and to see what was changed. I re-applied our patches again (re Japanese characters etc)