Refactor screenshot testing framework to allow multiple 'backends' other than phantomjs + allow toggled optimizations #7825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
May 2, 2015 20:32
… and create Platform object to contain platform setup work.
…eparate in IoC config & in source code.
…m w/o bigger refactoring.
…tect phantomjs + electron.
…to phantomjs platform object. (for screenshot testing lib)
… to ResembleLoader class.
…maining phantom object references to phantom Platform object and rely on node.js super globals.
…latform initialization.
…ronment global to run-tests.js file.
…ct in screenshot testing lib.
…form object. (for screenshot testing framework)
…ramework setup + mocha/chai/resemble setup + fixture setup).
diosmosis
added
Pull Request WIP
|
Thank you for this proposed pull request. Because it was last updated more than one month ago, it is our policy to close pull requests opened for a long time without updates. If you would like to continue work on the pull request, please simply ping us to have it re-opened (after you have pushed a new commit). We hope you understand this and we look forward to seeing an update from you on this pull request or another one! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a DI container to the screenshot testing lib, switches to using the node.js path/util modules (packaged on npm) + introduces a partially working electron platform backend. With some further work, a phantomcss backend could be created, though tests would likely have to be rewritten in that case.
Currently stalled on electron support due to lack of instrumentation tools. electron does not expose event posting/forwarding code to browser windows, so simulating clicks/keypresses/etc. is not directly possible. I know how to do it in C++ w/ chromium, so it's possible via an extension.
More to follow.