Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: MultiSites.getAll does not handle showColumns correct #7818

Closed
tsteur opened this issue May 3, 2015 · 0 comments
Closed

Regression: MultiSites.getAll does not handle showColumns correct #7818

tsteur opened this issue May 3, 2015 · 0 comments
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.13.1

Comments

@tsteur
Copy link
Member

tsteur commented May 3, 2015

This causes the All Websites Dashboard in Piwik Mobile to look like this:

ios simulator screen shot 04 may 2015 10 18 29

instead of

ios simulator screen shot 04 may 2015 10 18 35

Problem is the showColumns parameter which expects to be an array but the mobile app sends it as expected like nb_visits,visits_evolution: https://github.com/piwik/piwik/blob/2.13.0-rc3/plugins/MultiSites/API.php#L88
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label May 3, 2015
@tsteur tsteur self-assigned this May 3, 2015
@tsteur tsteur added this to the 2.13.1 milestone May 3, 2015
@tsteur tsteur mentioned this issue May 3, 2015
Merged
diosmosis added a commit that referenced this issue May 4, 2015
@diosmosis
Merge pull request #7819 from piwik/7818
1308aa8 
Fixes #7818 make sure MultiSites.getAll handles showColumns correctly when a comma separated list is used instead of an array of strings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.13.1
Development

No branches or pull requests
1 participant
@tsteur