All websites dashboard lists website names double encoded #7817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
| var createdSiteId = null; | ||
|
|
||
| before(function (done) { | ||
| var callback = function (undefined, response) { |
There was a problem hiding this comment.
The first argument to the callback will be an error (ie, it's a node.js style callback). If defined, you should call done(error) (where error is undefined renamed).
There was a problem hiding this comment.
I'm not sure if I understand.
Should I do something like this?
var callback = function (error, response) {
// ...
done(error, response)
}There was a problem hiding this comment.
More like:
var callback = function (error, response) {
if (error) {
done(error);
return;
}
...
done();
}
See: http://thenodeway.io/posts/understanding-error-first-callbacks/
diosmosis
added a commit
that referenced
this pull request
May 5, 2015
Fixes #7806, fix All websites dashboard lists website names double encoded error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #7806
Should be XSS safe. We do HTML decode in the browser but when outputting it in the browser, it will be encoded again by AngularJS