Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix report date to load by default #7814

Merged
merged 1 commit into from May 4, 2015
Merged

Fix report date to load by default #7814

merged 1 commit into from May 4, 2015

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented May 3, 2015

Fix for #7795

I'm not 100% sure, this feature is quite confusing, as you can see below it lacks consistency (or maybe I'm just not familiar with dates+periods enough). Here are the behaviors I've noted, please confirm that this is correct:

today     => date=today period=day
yesterday => date=yesterday period=day
month     => date=today period=month
week      => date=today period=week
last7     => date=last7 period=range
last30    => date=last30 period=range

I've added tests to cover this. On the left is the "preferred default date" stored in user preferences.

@mnapoli mnapoli added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 3, 2015
@mnapoli mnapoli added this to the 2.13.1 milestone May 3, 2015
@mnapoli mnapoli mentioned this pull request May 3, 2015
Closed
@diosmosis
Copy link
Member

I'm not 100% sure, this feature is quite confusing, as you can see below it lacks consistency (or maybe I'm just not familiar with dates+periods enough).

No, it's definitely confusing :)

@diosmosis
Copy link
Member

Looks like a working fix, I'm going to merge.

diosmosis added a commit that referenced this pull request May 4, 2015
@diosmosis
Merge pull request #7814 from piwik/fix-7795
e706eb2 
Fix report date to load by default, make sure default period is set using actual user preference and not using date inferred from user preference.
@diosmosis diosmosis merged commit e706eb2 into master May 4, 2015
@diosmosis diosmosis deleted the fix-7795 branch May 4, 2015 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.13.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mnapoli @diosmosis