Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI test for Rows count picker #7794

Closed
mattab opened this issue Apr 30, 2015 · 6 comments
Closed

UI test for Rows count picker #7794

mattab opened this issue Apr 30, 2015 · 6 comments
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Apr 30, 2015

We got a regression and noticed last minute in rc3 as there was no UI test for the feature. Let's add a UI test for tihs particular "Rows count" dropdown in the footer.

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Apr 30, 2015
@mattab mattab added this to the Piwik 2.14.0 milestone Apr 30, 2015
@mattab mattab added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Apr 30, 2015
@quba
Copy link
Contributor

quba commented Apr 30, 2015

Should be also added in 2.13.1 (fix is already there).

@mattab
Copy link
Member Author

mattab commented Apr 30, 2015

fyi @quba we fixed this issue just before 2.13.0 so it's actually working in the release

@mattab mattab modified the milestones: 2.13.1, Piwik 2.14.0 Apr 30, 2015
@diosmosis
Copy link
Member

If you mean the limit selector at the bottom of reports, there is a test here: https://github.com/piwik/piwik/blob/master/tests/UI/specs/ViewDataTable_spec.js#L81

@mattab
Copy link
Member Author

mattab commented May 6, 2015

Yes I mean this selector. I believe currently we don't take a screenshot but just click on it. The point is to take a screenshot of this selector so we don't regress the style like we almost did in 2.13.0.

@diosmosis
Copy link
Member

I think that won't be possible. I vaguely remember not being able to capture a screenshot of an open select element.

@diosmosis
Copy link
Member

Turns out it is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

3 participants