Do not set a visitorId if cookies are disabled #7783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
tsteur
added
not-in-changelog
mattab
pushed a commit
that referenced
this pull request
Apr 29, 2015
Do not set a visitorId if cookies are disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent from creating a new visit for each tracking request when eg
trust_visitors_cookies = 1is enabled. Currently, we create a new visit for every tracking request. Instead the visitor will be detected based on configId. Eg_paq.push(['trackPageView']);_paq.push(['trackPageView']);_paq.push(['trackGoal', '1']);Generates 3 visits.
Not sure re any side effects. I tested it locally and it worked for me.
refs #7780 #7778