before setting a new cookie domain, test whether it works to set a cookie on that domain #7781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to set a cookie on that domain
tsteur
added
not-in-changelog
|
looks good to me, it will improve Tracker accuracy eg. #7752 |
mattab
pushed a commit
that referenced
this pull request
Apr 29, 2015
before setting a new cookie domain, test whether it works to set a cookie on that domain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #7752
I tested on Chrome and it worked for me. Not sure re any side effects. This should fix the issue if a wrong
setCookieDomainis set, a new visitorId is created on every request.