Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

piwik.js: If cookies are disabled, no visitorId should be created / set #7780

Closed
tsteur opened this issue Apr 28, 2015 · 1 comment
Closed

piwik.js: If cookies are disabled, no visitorId should be created / set #7780

tsteur opened this issue Apr 28, 2015 · 1 comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.13.0

Comments

@tsteur
Copy link
Member

tsteur commented Apr 28, 2015

This means it will fallback to use configId. Otherwise we create a new visit on each tracker request (even when calling tracker methods multiple times within one pageview).

Background: If a idvisitor is given, we will always look for idvisitor but not for config_id eg https://github.com/piwik/piwik/blob/2.13.0-rc2/core/Tracker/Model.php#L337-L339 .

It goes into this code block for example if trust_visitors_cookies is enabled see https://github.com/piwik/piwik/blob/2.13.0-rc2/core/Tracker/Visitor.php#L141-L169 .

By not setting a idVisitor if cookies are disabled, it would actually look for the configId and not generate many visits

refs #7752
@tsteur tsteur mentioned this issue Apr 28, 2015
Merged
@mattab mattab changed the title piwik.js: If cookies are disabled, no visitorId should be created / set? piwik.js: If cookies are disabled, no visitorId should be created / set Apr 29, 2015
@mattab
Copy link
Member

mattab commented Apr 29, 2015

Marking as fixed since #7783 was merged - please re-open @tsteur if there is more work to do

@mattab mattab closed this as completed Apr 29, 2015
@mattab mattab added this to the Piwik 2.13.0 milestone Apr 29, 2015
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.13.0
Development

No branches or pull requests
2 participants
@tsteur @mattab