Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column Headers Missing in TSV / CSV data exports #7774

Closed
stphnwlkr opened this issue Apr 27, 2015 · 2 comments
Closed

Column Headers Missing in TSV / CSV data exports #7774

stphnwlkr opened this issue Apr 27, 2015 · 2 comments
Assignees
@diosmosis
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.14.0

Comments

@stphnwlkr
Copy link

When exporting data using Pages >> Row Evolution >> Export as TSV the column headers now read what appears to be the array position 0, 1, 2, 3, 4, 5, etc. and not the actual column labels. Versions 2.12.0 and 2.12.1

The issue can be reproduced at this URL on demo: demo.piwik.org
@tsteur
Copy link
Member

tsteur commented Apr 28, 2015

I can reproduce it. The link is also broken on all Graph reports. Eg Pie etc. It is caused by https://github.com/piwik/piwik/blob/2.13.0-rc2/plugins/CoreVisualizations/Visualizations/Graph.php#L62

which causes the disable_queued_filters=1 in the export link. Maybe we could use $this->requestConfig->disable_queued_filters = 1 instead? This would fix the export link but might break something else, not sure.

Alternatively, we need to apply the metrics column mapping in the CSV renderer but a better fix should be do not disable queued filters as it might break other things as well.

@mattab mattab added this to the Piwik 2.14.0 milestone Apr 28, 2015
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Apr 28, 2015
@mattab
Copy link
Member

mattab commented Apr 28, 2015

This would fix the export link but might break something else, not sure.

I'm wondering if there's any reason for this line at all, do you remember why we need to disable queued filters?

Moving to 2.14.0

@diosmosis diosmosis self-assigned this May 10, 2015
@diosmosis diosmosis mentioned this issue May 11, 2015
Merged
@mattab mattab changed the title Column Headers Missing Column Headers Missing in TSV / CSV data exports Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
4 participants
@diosmosis @tsteur @mattab @stphnwlkr