Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue Improve look when no data #7092 #7764

Closed

Conversation

saleemkce
Copy link
Contributor

Fix for issue #7092

@tsteur I have updated the css and now it looks as aligned to left with 15px padded (If you have different suggestion, please change this padding value. It looks neat for now) to left. It now affects many core pages because all report sections based on this class pk-emptyDataTable I have attached two screenshot how it looks after the update. I have checked throughout the site plus all widget sections. There is no css break. Please feel free to comment if it looks bad anywhere.

action_sitesearch

=> Screenshot @ sitesearch section.


visitor-location

=> screenshot @ visition->location area

@tsteur
Copy link
Member

tsteur commented Apr 27, 2015

Should we maybe set the following?

.widget .pk-emptyDataTable {
padding-left: 15px;
}

.pk-emptyDataTable {
padding-left: 11px;
}

I'd also love to get rid of the font-style: italic but not sure how other people see it. On my screen it doesn't look nice and is not really helpful either. What do you think?

I'd be happy with this change with the new padding-left but I reckon some others might want to stick to the old centered version @mattab ?

👍 for me after changing to padding-left: 11px for normal widgets.

@mattab
Copy link
Member

mattab commented Apr 28, 2015

sounds good to align the "there is no data for this report." to the left 👍 (on your screenshot it seems too much to the right stlil and not perfectly aligned with title, I guess that's why @tsteur you suggest 11px instead of 15px)

@saleemkce
Copy link
Contributor Author

@tsteur @mattab yea "padding-left: 11px" looks good too. I agree. Could you merge the branch and close down the issue if there is nothing more to discuss?

@mattab
Copy link
Member

mattab commented Apr 28, 2015

@saleemkce maybe you could make the change to 11px in your PR.

On my screen it doesn't look nice and is not really helpful either. What do you think?
+1 wondering what it looks like without italic?

@saleemkce
Copy link
Contributor Author

Hi Matthieu, I will do both (without italic) & (padding to 11px) changes and show (screenshots) here possibly later today. I am a bit busy.

@saleemkce
Copy link
Contributor Author

Here is the updated screenshot with padding-left:11px and italic removed,

css-alignment-updated-in-reports

Open the image in new tab to see it clearly. I didn't re-size window when capturing screenshot(picture looks just as it appeared on screen). I have committed these changes so as to avoid any conflicts or issues. If anything is wrong, please suggest.

@mattab
Copy link
Member

mattab commented Apr 29, 2015

Hi @saleemkce

I reckon this looks good now! well done.

I looked at "Files" tab in your pull request and as you can see it includes other commits. Could you try remove those extra commits from your pull request, or maybe create a new PR with only the commit that fixes the issue?

@saleemkce saleemkce closed this Apr 30, 2015
@saleemkce saleemkce deleted the bugfix-css-alignment-report branch April 30, 2015 18:02
@saleemkce
Copy link
Contributor Author

This pull has been moved here for your reference #7799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants