New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for issue Improve look when no data #7092 #7764
fix for issue Improve look when no data #7092 #7764
Conversation
Should we maybe set the following?
I'd also love to get rid of the I'd be happy with this change with the new padding-left but I reckon some others might want to stick to the old centered version @mattab ? 👍 for me after changing to |
sounds good to align the "there is no data for this report." to the left 👍 (on your screenshot it seems too much to the right stlil and not perfectly aligned with title, I guess that's why @tsteur you suggest 11px instead of 15px) |
@saleemkce maybe you could make the change to 11px in your PR.
|
Hi Matthieu, I will do both (without italic) & (padding to 11px) changes and show (screenshots) here possibly later today. I am a bit busy. |
Here is the updated screenshot with padding-left:11px and italic removed, Open the image in new tab to see it clearly. I didn't re-size window when capturing screenshot(picture looks just as it appeared on screen). I have committed these changes so as to avoid any conflicts or issues. If anything is wrong, please suggest. |
Hi @saleemkce I reckon this looks good now! well done. I looked at "Files" tab in your pull request and as you can see it includes other commits. Could you try remove those extra commits from your pull request, or maybe create a new PR with only the commit that fixes the issue? |
…ss-alignment-report
…emkce/piwik into bugfix-css-alignment-report
This pull has been moved here for your reference #7799 |
Fix for issue #7092
@tsteur I have updated the css and now it looks as aligned to left with 15px padded (If you have different suggestion, please change this padding value. It looks neat for now) to left. It now affects many core pages because all report sections based on this class pk-emptyDataTable I have attached two screenshot how it looks after the update. I have checked throughout the site plus all widget sections. There is no css break. Please feel free to comment if it looks bad anywhere.
=> Screenshot @ sitesearch section.
=> screenshot @ visition->location area