Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open source plugins now upload their builds artifacts to a public space #7761

Closed
mattab opened this issue Apr 24, 2015 · 2 comments
Closed

Open source plugins now upload their builds artifacts to a public space #7761

mattab opened this issue Apr 24, 2015 · 2 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.16.1

Comments

@mattab
Copy link
Member

mattab commented Apr 24, 2015

We noticed that currently some open source plugins like SecurityInfo and others upload their artifacts into a protected page. for open source plugins it would make sense to consistently upload builds artifacts publicly

Proposed steps:

  • for each open source plugin by Piwik/PiwikPro, in travis.yml, check/add UNPROTECTED_ARTIFACTS=1
  • maybe we edit the default travis template and add something like:
    `

    for core developers only: uncomment if this plugin is an open source plugin

    UNPROTECTED_ARTIFACTS=1

    `

the setting is documented in http://developer.piwik.org/guides/tests-travis-extended
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Apr 24, 2015
@mattab mattab added this to the Piwik 2.14.0 milestone Apr 24, 2015
@diosmosis diosmosis self-assigned this May 8, 2015
@mattab
Copy link
Member Author

mattab commented Jun 16, 2015

Hi @diosmosis Are you working on this? if not please remove your assignment so we know it is not worked on.

@mattab mattab modified the milestones: 2.14.1, 2.14.0 Jun 16, 2015
@diosmosis diosmosis removed their assignment Jun 16, 2015
@mattab mattab modified the milestones: 2.14.1, 2.15.0 Jul 16, 2015
@mattab mattab removed this from the 2.15.0 milestone Aug 9, 2015
@mattab mattab added this to the Short term milestone Sep 18, 2015
mattab added a commit to matomo-org/plugin-TasksTimetable that referenced this issue Feb 1, 2016
@mattab
Set UNPROTECTED_ARTIFACTS=1 refs matomo-org/matomo#7761
85789e7
mattab added a commit to matomo-org/plugin-CustomDimensions that referenced this issue Mar 15, 2016
@mattab
Remove un-necessary UNPROTECTED_ARTIFACTS=1, refs matomo-org/matomo#7761
86b4819 
 matomo-org/ui-tests-viewer#22
mattab added a commit to matomo-org/plugin-SecurityInfo that referenced this issue Mar 15, 2016
@mattab
Remove un-necessary UNPROTECTED_ARTIFACTS=1, refs matomo-org/matomo#7761
8579027 
 matomo-org/ui-tests-viewer#22
mattab added a commit to matomo-org/plugin-TasksTimetable that referenced this issue Mar 15, 2016
@mattab
Remove un-necessary UNPROTECTED_ARTIFACTS=1, refs matomo-org/matomo#7761
8212ef0 
 matomo-org/ui-tests-viewer#22
mattab added a commit to matomo-org/plugin-TreemapVisualization that referenced this issue Mar 15, 2016
@mattab
Remove un-necessary UNPROTECTED_ARTIFACTS=1, refs matomo-org/matomo#7761
7b7e5ac 
 matomo-org/ui-tests-viewer#22
mattab added a commit to matomo-org/plugin-QueuedTracking that referenced this issue Mar 15, 2016
@mattab
Remove un-necessary UNPROTECTED_ARTIFACTS=1, refs matomo-org/matomo#7761
a713764 
 matomo-org/ui-tests-viewer#22
mattab added a commit to matomo-org/plugin-Bandwidth that referenced this issue Mar 15, 2016
@mattab
Remove un-necessary UNPROTECTED_ARTIFACTS=1, refs matomo-org/matomo#7761
052d6c2 
 matomo-org/ui-tests-viewer#22
mattab added a commit to matomo-org/plugin-LoginLdap that referenced this issue Mar 15, 2016
@mattab
Remove un-necessary UNPROTECTED_ARTIFACTS=1, refs matomo-org/matomo#7761
baedd03 
 matomo-org/ui-tests-viewer#22
mattab pushed a commit to PiwikPRO/plugin-CustomTrackerJs that referenced this issue Mar 15, 2016
Add UNPROTECTED_ARTIFACTS=1 so artifacts are uploaded publicly
a00cf76 
When plugins are open source, artifacts can be uploaded publicly. as a result, developers don't need to specify login/password to the `tests:sync-ui-screenshots`

Refs matomo-org/matomo#7761
mattab pushed a commit to PiwikPRO/plugin-PlatformsReport that referenced this issue Mar 15, 2016
Add UNPROTECTED_ARTIFACTS=1 so artifacts are uploaded publicly
83fb6c7 
When plugins are open source, artifacts can be uploaded publicly. as a result, developers don't need to specify login/password to the `tests:sync-ui-screenshots`

Refs matomo-org/matomo#7761
mattab pushed a commit to PiwikPRO/plugin-SiteMigration that referenced this issue Mar 15, 2016
Add UNPROTECTED_ARTIFACTS=1 so artifacts are uploaded publicly
6f59923 
When plugins are open source, artifacts can be uploaded publicly. as a result, developers don't need to specify login/password to the `tests:sync-ui-screenshots`

Refs matomo-org/matomo#7761
This was referenced Mar 15, 2016
Closed
Closed
Closed
@mattab
Copy link
Member Author

mattab commented Mar 15, 2016

  • Created several PRs which will fix this issue for Piwik PRO open source plugins.
  • Added a rule in UI tests viewer that by default, all piwik/plugin-* plugins are assumed to be open source and so artifacts will upload publicly by default (saving us from editing all plugin travis.yml files in piwik org)

Considered fixed!

@mattab mattab closed this as completed Mar 15, 2016
@mattab mattab added this to the 2.16.1 milestone Mar 15, 2016
@mattab mattab removed this from the Mid term milestone Mar 15, 2016
@mattab mattab changed the title Open source plugins can upload their builds artifacts to a public space Open source plugins now upload their builds artifacts to a public space Apr 1, 2016
mattab added a commit to matomo-org/travis-scripts that referenced this issue Jul 19, 2016
@mattab
Artifacts will now upload publicly by default, unless PROTECTED_ARTIF…
3a4807e 
…ACTS=1 is set in travis.yml

follows up
matomo-org/matomo#6938
matomo-org/matomo#7761
matomo-org/ui-tests-viewer#22
@mattab mattab mentioned this issue Jul 19, 2016
Merged
mattab added a commit to matomo-org/travis-scripts that referenced this issue Jul 19, 2016
@mattab
Artifacts will now upload publicly by default, unless PROTECTED_ARTIF…
e6a2e9e 
…ACTS=1 is set in travis.yml (#28)

follows up
matomo-org/matomo#6938
matomo-org/matomo#7761
matomo-org/ui-tests-viewer#22
@mattab mattab mentioned this issue Jul 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.16.1
Development

No branches or pull requests
2 participants
@diosmosis @mattab