Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show search field in sites manager only if there is a paging #7758

Merged
merged 2 commits into from Apr 24, 2015
Merged

Show search field in sites manager only if there is a paging #7758

merged 2 commits into from Apr 24, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Apr 24, 2015

refs #7747

@mattab
Copy link
Member

mattab commented Apr 24, 2015

Problem with this solution:

  • to reproduce you need eg 30 websites
  • search for a string in website manager
  • then remove the text from the search field
    • got: the whole search field disappears
    • expected: search field should not disappear

@tsteur
Copy link
Member Author

tsteur commented Apr 24, 2015

@mattab can you retry?

mattab pushed a commit that referenced this pull request Apr 24, 2015
Merge pull request #7758 from piwik/sitesmanager_search_field_only_on…
a094f69 
…_paging

Show search field in sites manager only if there is a paging
@mattab mattab merged commit a094f69 into master Apr 24, 2015
@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Apr 24, 2015
@mattab mattab added this to the Piwik 2.13.0 milestone Apr 24, 2015
@mattab mattab mentioned this pull request Apr 24, 2015
Closed
@mnapoli mnapoli deleted the sitesmanager_search_field_only_on_paging branch May 10, 2015 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @mattab