Fixes #3135, fix opt-out form on Safari browsers by opening new window that sets the cookie. #7754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w that sets the cookie.
diosmosis
added
Pull Request WIP
| @@ -320,21 +320,34 @@ public function trackingCodeGenerator() | |||
| */ | |||
| public function optOut() | |||
| { | |||
| $reref = Common::getRequestVar('reref', false); | |||
| if (!empty($reref)) { | |||
| Url::redirectToUrl($reref); | |||
There was a problem hiding this comment.
here is a security vulnerability, "Open redirect": https://www.owasp.org/index.php/Open_redirect
could it be avoided?
There was a problem hiding this comment.
actually that's dead code from one of the other attempts at fixing the problem. It can be removed, thanks for catching it!
added 9 commits
April 24, 2015 07:02
… exist. If it exists, we don't need to visit in a new window.
… can keep clicking the checkbox.
…m is done submitting.
…iable and added opt-out form screenshot tests.
diosmosis
removed
the
Pull Request WIP
added 14 commits
April 26, 2015 15:18
…window is loaded (also when JS is available, use window.open instead of a form POST).
added 2 commits
April 26, 2015 17:03
…n using in submitForm function in optOut.twig.
|
created new FAQ https://piwik.org/faq/general/faq_20000/ |
|
Can you smash commits into one and then +1 to merge |
|
Merged in 7cc3bfc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
This PR allows us to set 3rd party cookies in the opt-out form for Piwik. It works by opening a new window on form submission, reloading the new window, and setting the cookie on this reload. It is necessary to reload the window, because the session cookie isn't set, so the nonce won't be detected & so, the ignore cookie won't be set.
It works whether JavaScript is enabled or not, and other browsers still get the better UX.
I tried two alternative solutions to provide better UX, but neither worked on the latest version of Safari (Safari 8):
I first tried to do the form POST as an AJAX request and set the cookies manually via JavaScript. This failed when trying to read the cookies sent by the POST; Safari would not allow reading the Set-Cookie response.
I also tried the triple redirect solution described here: http://measurablewins.gregjxn.com/2014/02/safari-setting-third-party-iframe.html?m=1
This failed due to the same origin policy. The iframe cannot access the
topframe unless they both come from the same domain. It might be possible for the website hosting the iframe to allow this, but Piwik can't control whether the website does this.Tested on Safari in a Mac and on an iPhone.
TODO:
Refs #3135