Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widgets containing sparklines should list the sparklines one per line #7738

Closed
mattab opened this issue Apr 22, 2015 · 2 comments
Closed

Widgets containing sparklines should list the sparklines one per line #7738

mattab opened this issue Apr 22, 2015 · 2 comments
Assignees
@mnapoli
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.13.0

Comments

@mattab
Copy link
Member

mattab commented Apr 22, 2015

after including the bootstrap grid, the UI tests showed that the "Frequency overview" widget regressed and now displays sparklines in two columns instead of below one another.

Got:
frequency overview

Expected:

34f79e80-a6c3-11e4-99a2-829300ada44e
@mattab mattab added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Apr 22, 2015
@mattab mattab modified the milestones: Mid term, Piwik 2.13.0 Apr 22, 2015
@mnapoli mnapoli self-assigned this Apr 22, 2015
mnapoli added a commit that referenced this issue Apr 22, 2015
@mnapoli
Fixes #7738 visual regression in the visits frequency
779b48b
@mnapoli mnapoli mentioned this issue Apr 22, 2015
Merged
@mnapoli
Copy link
Contributor

mnapoli commented Apr 22, 2015

PR: #7740

@mattab
Copy link
Member Author

mattab commented Apr 22, 2015

Reopening as there are some more widgets with the issue:

Goals overview

widget bis

Visits overview

widget3

Visits overview (with graph)

widget two columns

  • let's make those also one sparkline per line

@mattab mattab reopened this Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnapoli mnapoli

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.13.0
Development

No branches or pull requests
2 participants
@mattab @mnapoli