Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover Confirmation yes/no has slightly regressed in style #7722

Closed
mattab opened this issue Apr 21, 2015 · 0 comments
Closed

Popover Confirmation yes/no has slightly regressed in style #7722

mattab opened this issue Apr 21, 2015 · 0 comments
Assignees
@diosmosis
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
2.13.0

Comments

@mattab
Copy link
Member

mattab commented Apr 21, 2015

The popover in git does not look as it used to

Expected

beforepoover

Got

dialog_1024

There are small changes:

  • the text looks bigger
  • there is a grey line

Steps

  • add UI test for Popover
  • fix issue
@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels Apr 21, 2015
@mattab mattab added this to the Piwik 2.13.0 milestone Apr 21, 2015
@diosmosis diosmosis self-assigned this Apr 21, 2015
diosmosis pushed a commit that referenced this issue Apr 22, 2015
Refs #7722, add UI test for UI confirmation dialog in segment selecto…
ebae552 
…r test and fix existing segment selector test that did not actually delete a segment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.13.0
Development

No branches or pull requests
2 participants
@diosmosis @mattab